How to get minify code?

I want get minify code after build , and my unbuild config this:

import { defineBuildConfig } from "unbuild";

export default defineBuildConfig({
  entries: ["./index"],
  declaration: true,
  clean: true,
  failOnWarn: false,
  rollup: {
    emitCJS: true,
    esbuild: {
      minify: true
    }
  }
});

But after pnpm build , I get this error:

Error building E:/project/changan-incall/packages/microApp: Error: Transform failed with 1 error:
<stdin>:1:10: ERROR: Expected ";" but found "EnterMicroAppParams"
Error: Transform failed with 1 error:
<stdin>:1:10: ERROR: Expected ";" but found "EnterMicroAppParams"
    at failureErrorWithLog (E:\project\changan-incall\node_modules\.pnpm\esbuild@0.15.6\node_modules\esbuild\lib\main.js:1624:15)
    at E:\project\changan-incall\node_modules\.pnpm\esbuild@0.15.6\node_modules\esbuild\lib\main.js:1413:29
    at E:\project\changan-incall\node_modules\.pnpm\esbuild@0.15.6\node_modules\esbuild\lib\main.js:678:9
    at handleIncomingPacket (E:\project\changan-incall\node_modules\.pnpm\esbuild@0.15.6\node_modules\esbuild\lib\main.js:775:9)
    at Socket.readFromStdout (E:\project\changan-incall\node_modules\.pnpm\esbuild@0.15.6\node_modules\esbuild\lib\main.js:644:7)
    at Socket.emit (node:events:526:28)
    at addChunk (node:internal/streams/readable:315:12)
    at readableAddChunk (node:internal/streams/readable:289:9)
    at Socket.Readable.push (node:internal/streams/readable:228:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:190:23) {
  errors: [
    {
      detail: undefined,
      id: '',
      location: [Object],
      notes: [],
      pluginName: '',
      text: 'Expected ";" but found "EnterMicroAppParams"'
    }
  ],
  warnings: [],
  code: 'PLUGIN_ERROR',
  plugin: 'esbuild',
  hook: 'renderChunk'
}

How Can I resolve this ? Hope get you help genuine.

[dwightjack]

I submitted a quick PR that should fix this issue: https://github.com/unjs/unbuild/pull/185

[dwightjack]

I guess @Phl3bas is correct. rollup-plugin-dts doesn’t seem to work well with the esbuild plugin used in unbuild. For what I can understand, the esbuild plugin tries to load and minify .d.ts file chunks generated by the dts plugin with the js loader (source) which causes an error because the generated TS definition is not valid JavaScript:

declare function sum(a: number, b: number): number;
//      ^--- esbuild breaks here

unbuild runs two rollup builds, one to transform the source to JS and one (optional) to generate the TS definitions. I managed to fix the issue using the rollup:dts:options hook which receives the option passed to the TS definitions build:

import { defineBuildConfig } from 'unbuild'

export default defineBuildConfig({
  entries: [
    'src/index',
  ],
  declaration: true,
  clean: true,
  rollup: {
    emitCJS: true,
    esbuild: {
        minify: true,
        target: 'es2015',
    }
  },
  hooks: {
    'rollup:dts:options'(_ctx, options) {
    
      if (Array.isArray(options.plugins)) {
        // find the esbuild plugin instance
        const esbuildPlugin = options.plugins.find((p) => (p as any).name === 'esbuild');
        // renderChunk is where the minification happens
        // but we don't want it to be executed
        // on the TS declaration build 
        (esbuildPlugin as any).renderChunk = () => null
      }
    }
  }
})

This is more of a hack than a workaround, so I guess we should fix the issue with a PR.