Some typo in tests

Hi this test actually return 3 but expected to be 2 which is wrong

Deno.test("adds the element", async () => {
  const key = newKey();
  const value1 = randomID();
  const value2 = randomID();

  await new LPushCommand([key, value1]).exec(client);
  const res = await new LInsertCommand([key, "before", value1, value2]).exec(
    client,
  );
  assertEquals(res, 2);
});

[rebaz94]

@chronark I have one question about spop command why the TResult type parameter is string? if count defined the result will be list of string

export class SPopCommand<TData> extends Command<
  string | null, // i think it should be string[] | string | null
  TData | null
> {
  constructor(
    [key, count]: [key: string, count?: number],
    opts?: CommandOptions<string | null, TData | null>,
  ) {
    const command: unknown[] = ["spop", key];
    if (typeof count === "number") {
      command.push(count);
    }
    super(command, opts);
  }
}

[rebaz94]

according to Redis documentation for spop Removes and returns one or more random members from the set value store at key.

but in the test said return the first element

Deno.test("without count", async (t) => {
  await t.step("returns the first element", async () => {
    const key = newKey();
    const member = randomID();
    await new SAddCommand([key, member]).exec(client);
    const res = await new SPopCommand([key]).exec(client);
    assertEquals(res, member);
  });
});

Deno.test("with count", async (t) => {
  await t.step("returns the first n elements", async () => {
    const key = newKey();
    const member1 = randomID();
    const member2 = randomID();
    const member3 = randomID();
    const member4 = randomID();
    await new SAddCommand([key, member1, member2, member3, member4]).exec(
      client,
    );
    const res = await new SPopCommand<string[]>([key, 2]).exec(client);

    assertEquals(res?.length, 2);
    assertEquals([member1, member2, member3, member4].includes(res![0]), true);
    assertEquals([member1, member2, member3, member4].includes(res![1]), true);
  });
});