question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

A couple questions on usage of this library

See original GitHub issue

Hi, thanks for creating this great and nice looking component! I’ve got a couple of questions before deciding whether we can use this in our application.

  1. Currently this library has peerDependencies on React v0.14 and v15. Are there any plans to upgrade to React v16, which is the current version (and higher, as they are released in the future)?
  2. The icons used for folders, files, etc. are based on an old version of FontAwesome (v4). Are there plans to upgrade to the newer version (v5)?
  3. We would like to have our own custom columns in the table, which would include renaming the headers as well as displaying some dropdown fields in the ‘file rows’.
    • I saw you had a great many hooks to customize the behavior of this library. However, I was not yet able to find hooks that would support renaming headers, adding columns, etc. Am I missing something?
    • One option I found was to use the headerRenderer prop and write a custom Header component, however, this would copy the whole TableHeader component in your implementation and rename some values. Similar for fileRenderer, of course. Is this the intended way of customizing the table? It doesn’t seem particularly DRY.
    • I tried the above approach of copying and customizing the Header component, but once I add the DropTarget to the component, it doesn’t show up anymore. Any clue as to why that is the case? Could this be the case because your library is on v2.x of react-dnd and react-dnd-html5-backend, while our’s is on v5.x? If so, are there plans to upgrade?
  4. I wasn’t able to find any documentation except for the live demo. Is there more documentation to be found? Until now I’ve tried to piece together the ‘documentation’ from reading the code itself.
  5. We’re using TypeScript in our project, so it would really help us out if there were some type definitions available. Do you have any plans for adding those in the future?

We would really like the component, but these are some of the problems we encountered with it so far. In general it would probably already help a lot if the dependencies could be upgraded. Usually I would try to contribute something here, but I’m not yet sure how much time I’ll have for that in the upcoming months.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
jarekwgcommented, Sep 5, 2018

React16 support is now listed in package.json in the 1.3.1 release. Also, re fontawesome, we might end up stripping it out of here altogether and asking the user to feed their own icon mapping in. (More of a hassle, but makes it more open to competing icon libraries). No ETA on any of that though.

1reaction
rvanheestcommented, Sep 1, 2018

Hi, thanks for the response! We’ll see how far we can come using the library. My colleagues definitely love all the nice features it has, so we’ll be trying getting it to work. Of course I’d be interested to see the further development of this component.

Read more comments on GitHub >

github_iconTop Results From Across the Web

c# - A couple of questions regarding on OO and library design ...
1. Should a library be self-sufficient? Libraries can surely use, for example, Dependency Injection frameworks. However, it is debatable whether you want to ......
Read more >
Couple of questions | WordPress.org
How well would the S3 cloud sync work with a site that has 9,000+ images (probably more files, when you consider thumbnail sizes)?...
Read more >
BCC LIBRARY REFERENCE SURVEY - Berkeley City College
Do you go to other libraries to do research for your BCC courses? YES NO ... Did the librarian use a follow-up question?...
Read more >
Question-Answer Relationship (QAR) | Classroom Strategies
Why use the question-answer relationship strategy? It can improve students' reading comprehension. It teaches students how to ask questions about their reading ...
Read more >
Top 10 Questions Students ask about ACC Library Services
Items may be renewed once if no one else has requested them. 5. Where can I use a computer on campus? Bring your...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found