Accessing HTTPS sites through proxy

Why is it that urllib3 doesn’t allow proxy access to HTTPS sites? See poolmanager.py#L416. This limitation seems to be also reflected in the requests library as well.

poolmanager.py#L416

    def connection_from_host(self, host, port=None, scheme='http', pool_kwargs=None):
        if scheme == "https":
            return super(ProxyManager, self).connection_from_host(
                host, port, scheme, pool_kwargs=pool_kwargs)

        return super(ProxyManager, self).connection_from_host(
            self.proxy.host, self.proxy.port, self.proxy.scheme, pool_kwargs=pool_kwargs)

requests/adapters.py#L346

    def request_url(self, request, proxies):
        """Obtain the url to use when making the final request.
        If the message is being sent through a HTTP proxy, the full URL has to
        be used. Otherwise, we should only use the path portion of the URL.
        This should not be called from user code, and is only exposed for use
        when subclassing the
        :class:`HTTPAdapter <requests.adapters.HTTPAdapter>`.
        :param request: The :class:`PreparedRequest <PreparedRequest>` being sent.
        :param proxies: A dictionary of schemes or schemes and hosts to proxy URLs.
        :rtype: str
        """
        proxy = select_proxy(request.url, proxies)
        scheme = urlparse(request.url).scheme

        is_proxied_http_request = (proxy and scheme != 'https')
        using_socks_proxy = False
        if proxy:
            proxy_scheme = urlparse(proxy).scheme.lower()
            using_socks_proxy = proxy_scheme.startswith('socks')

        url = request.path_url
        if is_proxied_http_request and not using_socks_proxy:
            url = urldefragauth(request.url)

        return url

[glaukon-ariston]

Is there a roadmap of what needs to be done to support HTTPS over proxy in urllib3? How much work is it? What has already been done so far? Is there a single point in the httplib/http.request that is the root of the problem? Is there a reference implementation you can recommend. I would appreciate any specific details you can provide.

[OmriBaso]

Google ״Omri Baso besocurl״ I wrote a library for that guys

בתאריך שבת, 19 ביוני 2021 ב-17:31 מאת Seth Michael Larson < @.***>:

Closed #1520 https://github.com/urllib3/urllib3/issues/1520.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/urllib3/urllib3/issues/1520#event-4912534082, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMA7VQD4TIW6YSHBOZ5PRZDTTSS53ANCNFSM4GPOFRVQ .