Deprecate urllib3.request module

Context

After adding the top-level request() method, We have a function named request in urllib3.__init__.py and a module named request(urllib3.request.py). It changes the from request import request behavior.

• Old behavior: importing request module.
• New behavior: importing request function.

Possible Solution

• We could rename the request module to urllib3.request_methods and add a deprecated module urllib3.request.
• We have to raise an AttributeError when accessing request.RequestMethods

Contribution

Would you be willing to submit a PR? (Help can be provided if you need assistance submitting a PR)

[atodorov]

Probably it’s the same issue but following the instructions from the website:

>>> import urllib3
>>> resp = urllib3.request("GET", "https://httpbin.org/robots.txt")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'module' object is not callable

Not a good first-user experience. At least update the documentation.

[pquentin]

This is all very true, unfortunately urllib3 painted itself into a corner by documenting its internals as public APIs.