HTTPConnection should return urllib3.HTTPResponse instead of http.client.HTTPResponse

Part of https://github.com/urllib3/urllib3/issues/1985

Currently our urllib3.connection.HTTPConnection classes return directly a http.client.HTTPResponse. This ties our APIs directly to http.client which isn’t desirable for future additions of new HTTP protocol implementations.

Instead our HTTPConnection APIs should return an instance of urllib3.response.HTTPResponse directly and should be forwarded upwards instead of doing the wrapping inside of HTTPConnectionPool.urlopen.

Minimum requirements

• Research and understand which exceptions can be raised at which stage from HTTPConnection.urlopen and HTTPConnection.getresponse in both urllib3 and http.client. This research should be posted into this issue.
• Move the wrapping of http.client.HTTPResponse from HTTPConnectionPool to HTTPConnection
• Update type hints for HTTPConnection
• Add test cases for HTTPConnection directly returning a urllib3.response.HTTPResponse.
• Change existing test cases for the new logic.

[sethmlarson]

@shadycuz It sounds like you’re on the right path!

[shadycuz]

I think super is mostly fixed? I can’t remember. Still need to fix the bare raise bug. I did publish the first tool Deep-AST that makes it possible to parse all callable code.

I plan on releasing a second tool that will address the bug in the bare raise.