question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Notify packages using urllib3[secure] about it's deprecation

See original GitHub issue

💵 You can get paid to complete this issue! Please read the docs for more information.

Packages to notify

  • selenium
  • scout-apm
  • cpp-coveralls
  • sentry
  • awscurl
  • mastercard-api-core
  • mastercard-oauth1-signer
  • cloud-files
  • google-assistant-sdk
  • minet
  • cloud-volume
  • azure-cli-appservice
  • runway-python
  • lyricsmaster
  • pyramid-oereb
  • flexmeasures
  • optimove
  • comet-git-pure

What to do for each package

  • Find the source repository (GitHub/GitLab/BitBucket/etc)
  • Create a PR which includes the following:
    • Mentions that pyOpenSSL and urllib3[secure] are deprecated in the upcoming release (1.26.12)

    • Links to https://github.com/urllib3/urllib3/issues/2680

    • Removes [secure] extra from the urllib3 dependencies

    • If needed, add pyOpenSSL>=0.14, cryptography>=1.3.4, idna>=2, and certifi to their dependencies. These dependencies should only be added back if they’re actually used within the project. If they’re not used (including pyopenssl.inject_into_urllib3) then they can likely be omitted.

    • If urllib3.contrib.pyopenssl.inject_into_urllib3 is used anywhere in the project (search for inject_into_urllib3) then make the change to the following:

      try:
          import ssl
      except ImportError:
          ssl = None
      
      if not getattr(ssl, "HAS_SNI", False):
          from urllib3.contrib import pyopenssl
      
          pyopenssl.inject_into_urllib3()
      

      This is the logic that is used in Requests to only use pyOpenSSL if SNI isn’t available (which is very rare).

  • After creating each PR, add it as a comment to this issue.

PRs don’t need to be merged to complete this issue, we only want to create the PRs so that maintainers of these projects are aware of the upcoming changes.

Part of https://github.com/urllib3/urllib3/issues/2680

Issue Analytics

  • State:closed
  • Created a year ago
  • Reactions:1
  • Comments:36 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
fyunusacommented, Aug 10, 2022

Hi @sethmlarson sentry doesn’t seem to use the [secure] extra for urllib3 https://github.com/getsentry/sentry-python/

0reactions
fyunusacommented, Aug 12, 2022

OK @sethmlarson thanks to you too, I’ll try to do a follow up on the PRs also.

Read more comments on GitHub >

github_iconTop Results From Across the Web

User Guide - urllib3 1.26.13 documentation
First things first, import the urllib3 module: ... If you install urllib3 with the secure extra, all required packages for certificate verification on ......
Read more >
vRealize Operations 8.6 (87037) | VMware KB
This article covers the fixes made in vRealize Operations 8.6 from previous versions. The following issues have been resolved as of vRealize ...
Read more >
How to use the urllib3.HTTPSConnectionPool function in urllib3
request("GET", "/") assert r.status == 200 assert warn.called # Modern versions of Python, or systems using PyOpenSSL, only emit # the unverified ...
Read more >
Pulse Secure Services Director Licensing Acknowledgements
2019 Pulse Secure, LLC. Software That Uses the Apache 2.0 License. The following software packages are subject to the Apache 2.0 software ...
Read more >
translation - Kaggle
You should install packages reliably by using venv: https://pip.pypa.io/warnings/venv Note: you may need to restart the kernel to use updated packages.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found