Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Vendor ssl.match_hostname to avoid Python 3.10 deprecation warning
See original GitHub issueAs reported by @AdamWill in https://github.com/urllib3/urllib3/issues/2200#issuecomment-931759912, we’re issuing deprecation warnings for using ssl.match_hostname() on Python 3.10:
/usr/lib/python3.10/site-packages/urllib3/connection.py:542: DeprecationWarning: ssl.match_hostname() is deprecated
match_hostname(cert, asserted_hostname)
We should probably fix that as we’re relying on users fixing 1.26.x deprecation warnings before moving to 2.0. In that case, the fix is vendoring ssl.match_hostname() as SSLContext.check_hostname does not support all our needs such as fingerprintings. Look at this main commit for inspiration of what should be done in the 1.26.x branch: https://github.com/urllib3/urllib3/pull/2198
Issue Analytics
- State:
- Created 2 years ago
- Comments:11 (7 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@chetanugale @Pradhvan Because there’s some time sensitivity to this PR I’d recommend both of you work on this and whoever has a PR that’s ready to merge first will be merged. Not trying to turn this into a race, I just know that I’m also guilty of committing to an OSS contribution but not quite sure when it’ll get done due to real life concerns.
Thank you both for being interested in this, it’s very appreciated. Hope that either way you’ll both be interested in contributing other issues as well 🙇
I can give it a shot. 😄