Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Feature Request: Allow Ribbon to be applied other icons

See original GitHub issue

Really pleased to see this library picked up from where the last dev left off.

Whilst this works great for an app with a single entry point, we have an app with multiple launcher activities it would be good to be able to apply the ribbon to them all.

I believe you are currently limited to just the icon and round icon in the application tag of the manifest by:

public static List<String> getLauncherIcons(File manifestFile) throws SAXException, IOException {
  GPathResult manifestXml = xmlSlurper.parse(manifestFile);
  GPathResult applicationNode = (GPathResult) manifestXml.getProperty("application");
  String icon = String.valueOf(applicationNode.getProperty("@android:icon"));
  String roundIcon = String.valueOf(applicationNode.getProperty("@android:roundIcon"));
...

But this doesn’t check for activities or activity-alias’es with potentially a different icon and android.intent.category.LAUNCHER

A way to give the library a list of icon paths to ribbonize would be ideal, and probably a lot easier/cleaner than iterating the manifest.

Issue Analytics

State:
Created 3 years ago
Comments:7 (3 by maintainers)

Top GitHub Comments

2reactions

issue-label-bot[bot]commented, Sep 23, 2020

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

1reaction

ac87commented, Sep 28, 2020

Tested with debug build and the multiple icons are all decorated as expected. Thank you very much.