Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Incompatibility with Gerrit <= v2.14

See original GitHub issue

When using the Java client with Gerrit v2.14 (or earlier) the ChangeApiRestClient.get() would cause Gerrit to fail with the following error: com.urswolfer.gerrit.client.rest.http.HttpStatusException: Request not successful. Message: Bad Request. Status-Code: 400. Content: "TRACKING_IDS" is not a valid value for "-o"..

This is causing the Gerrit Code Review plugin for Jenkins to fail (see reported Issue JENKINS-60364).

Issue Analytics

State:
Created 4 years ago
Comments:11 (11 by maintainers)

Top GitHub Comments

1reaction

lucamilanesiocommented, Dec 30, 2019

True, but that option may not be available anyway in the version of Gerrit. It would be best IMHO to have the Gerrit client API to manage that complexity rather than having all the applications having to deal with it.

I’m just wondering what happens when an option is requested, but the client knows that this option is not supported by the Gerrit server which is connected?

I was thinking about exposing the list of supported options for the current detected version of the server that the client is connected to. Then, even after knowing them, if the client is explicitly using an unsupported option, he will get an exception, which is expected.

If no options are passed, the client will get all the possible options supported by the remote Gerrit server version.

Hope that would make sense.

0reactions

lucamilanesiocommented, Jan 16, 2020

Thanks @uwolfer for your help in getting this merged and released 😃