Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

1.7.0 moved jQuery to peerDependencies which is a breaking change

See original GitHub issue

Expected behaviour

npm install bootstrap-datepicker@^1.0.0 should install jQuery as its own dependency as before

Actual behaviour

npm install bootstrap-datepicker@^1.0.0 instead doesn’t install jQuery as it is moved to peerDependencies which broke our already released versions of packages which depend on bootstrap-datepicker.

Issue Analytics

State:
Created 6 years ago
Comments:12 (5 by maintainers)

Top GitHub Comments

3reactions

einfallstollcommented, Apr 17, 2020

What’s the status here? 2.0.0 is still not released, but I think moving jQuery to peerDependencies makes sense as stated in #2399. Could we publish 2.0.0 early and move the remaining breaking changes to 3.0.0?

0reactions

setefocoscommented, Aug 8, 2020

It is breaking with Webpack. that is instantiating a new jquery object just for bootstrap-datepicker. The jquery instance of our project ends with no .datepicker function. “peerDependencies” solves that. Please update package.json! It requires a major version bump, because it forces projects that uses bootstrap-datepicker to have jquery dependencie declared on the own package.json.

In my opinion, a lot of people is doing an ungly workround do deal with it, since webpack is the most used build tool. https://2019.stateofjs.com/other-tools/build_tools