Dialog doesn't prevent the execution of clickshortcuts behind it

When I create a view with a Shortcut Listener (Enter) on a button and the view opens a “Add XYZ Dialog” for some additional content - I would expect that I can create a second Shortcut Listener within the Dialog and the Dialog prevents that both Enter Shortcuts are executed.

Only the Shortcut Listener within the Dialog should be executed. Currently both Shortcuts are executed.

This creates weird side effects. Additionally any Dialog should be modal (WCAG) - that mean’s that interacting with the content behind it SHOULD BE impossible.

Vaadin: 14.1.19 Browser: FF 74

How to test:

1. Click Open Dialog
2. Press Enter
3. 2 Notification are displayed. It should only be one visible

@Route("shortcut")
public class ShortcutBug extends VerticalLayout {

  public ShortcutBug() {
    add(new Button("Open Dialog", e -> {
      Button myDialogButton = new Button("Hit Enter", event -> {
        Notification.show("Enter was called", 2000, Position.TOP_START).addThemeVariants(NotificationVariant.LUMO_SUCCESS);
      });
      myDialogButton.addClickShortcut(Key.ENTER);
      Dialog dialog = new Dialog(myDialogButton);
      dialog.open();
    }));

    Button myNonDialogButton = new Button("Should not be called by the other Other Enter Shortcut", e -> {
      Notification.show("ERROR: Enter was called", 5000, Position.TOP_START).addThemeVariants(NotificationVariant.LUMO_ERROR);
    });
    myNonDialogButton.addClickShortcut(Key.ENTER);

    add(new Hr(), myNonDialogButton);
  }
}

[pleku]

Right, that sentence doesn’t make sense as router links can be inside the modal dialogs too and should thus work. I’ll slap the author with a large 🐟 and fix it

[knoobie]

@pleku I personally would expect router link to work within the dialog but the following comment made me question myself 😃

        // When the UI is made inert, all router link navigation is
        // ignored. For the part of the UI that is not inert, navigation
        // could be allowed by using something else than router links (with
        // server side listeners).

Because the second sentence said “not inert = navigation could be allowed by using something else than router links”