Error "Can't move a node from one state tree to another." when re-adding a previously removed component after refreshing with @PreserveOnRefresh

Description of the bug

If a component is added and then removed from a component that is preserved on refresh, trying to add it again after refreshing results in the error

java.lang.IllegalStateException: Can't move a node from one state tree to another. If this is intentional, first remove the node from its current state tree by calling removeFromTree

Minimal reproducible example

Code below. Steps to reproduce:

1. Click the first button
2. Click the second button
3. Refresh the page
4. Click the first button again

---

import com.vaadin.flow.component.Text;
import com.vaadin.flow.component.button.Button;
import com.vaadin.flow.component.html.Div;
import com.vaadin.flow.component.orderedlayout.VerticalLayout;
import com.vaadin.flow.router.PreserveOnRefresh;
import com.vaadin.flow.router.Route;

@Route("")
@PreserveOnRefresh
public class MainView extends VerticalLayout {
    public MainView() {
        Text text1 = new Text("Text 1");
        Text text2 = new Text("Text 2");

        Div container = new Div();

        Button button1 = new Button("Set text 1", e -> {
            container.removeAll();
            container.add(text1);
        });
        Button button2 = new Button("Set text 2", e -> {
            container.removeAll();
            container.add(text2);
        });

        add(button1, button2, container);
    }
}

Expected behavior

Text 2 is replaced by Text 1.

Actual behavior

An exception is thrown

java.lang.IllegalStateException: Can't move a node from one state tree to another. If this is intentional, first remove the node from its current state tree by calling removeFromTree

Versions:

• Vaadin 14.1.27, Flow 2.1.9
• Java version: openjdk 11.0.4
• OS version: Windows 10
• Application Server (if applicable): Spring Boot embedded Tomcat

[denis-anisimov]

Confirmed.

Thank you very much for precise and short steps to reproduce. 👍

[denis-anisimov]

This ticket was absolutely specific for @PreserveOnRefresh. The reason has been identified based on provided code sample and fixed. So this ticket is fixed and closed.

If you see another issue then please:

• create another ticket.
• provide exact steps to reproduce
• it might be that this ticket should be made in the Dialog repository.

Please note that the exception doesn’t identify the ticket. Especially if there is no stackrace. The issue is identified by the steps to reproduce. This happens for me even without using @PreserveOnRefresh : this is a clear indicator that this is a totally different issue.