[vite] The offline path is requested regardless of the original path when online in dev mode

Description of the bug

The service worker always requests the offline path in dev mode even if the original request path is different. Although this makes sense when the app is offline, it is absolutely incorrect when the app is online.

The related code fragment:

https://github.com/vaadin/flow/blob/1bc5ff8606942cf611ed612f2f8a7bff2adc23a8/flow-server/src/main/resources/com/vaadin/flow/server/frontend/sw.ts#L92-L101

Expected behavior

When the app is online, the service worker should not modify HTTP requests.

When the app is offline, the service worker should redirect HTTP requests to the offline path.

Minimal reproducible example

1. Clone https://github.com/vaadin/cookbook
2. Run mvn
3. Open http://localhost:8080/css-from-java

Expected:

<meta name="description" content="This recipe shows how to inject small CSS class definitions into the current page from Java.">

Actual:

<meta name="description" content="Find ready to use solutions and code snippets for common development problems and UX patterns. Includes Vaadin examples in Java and TypeScript.">

Versions

• Vaadin / Flow version: 23
• Java version: 17
• OS version: Mac OS

[taefi]

Thanks! That’s correct, I misunderstood it. It always adds the <meta> tag with the value for the root.

[Artur-]

You should see it when you have the server running, http://localhost:8080/css-from-java open and press refresh in the browser