TypeScript definitions

Hi, just wanted to stop by and leave a comment to tell you how awesome I think this package is. I’ve been messing around with it, and decided to try doing something with it with typescript and redux.

I’ve pushed ink-typescript-redux-test which is essentially the Counter example, but with more awesomeness.

• I’ve created a basic typescript definition for ink, contained in the custom_typings/ink directory.
• Uses redux for state
• Uses typescript-fsa for action creators and typescript-fsa-reducers for the reducer

If you want to include the typings in your project, feel free.

[xdave]

Yeah, no problem! Drop me a line if you want help with it, or if you want to write the whole thing in Typescript (which would eliminate the need to maintain separate bindings 😃, lol)

[rozzzly]

If I’m working with some-pkg and notice that its’ type defs are outdated, I’ll usually try to fix them. However, if the typedefs are provided by @types/some-pkg which means the definitions are stored in DefinitelyTyped/DefinitelyTyped I won’t even bother, I’ll create a new file in ./type-stubs containing just declare module 'some-pkg'; and say f🎉ck it. Because a) that repo won’t even load in my browser because there’s so many files in it b) the people there are snobby about writing tests even for minor changes c) the issues/PR sections have issues/PRs from thousands of other packages and my changes get drowned out

That’s why I prefer typedefs be kept in the same repo as the projects source. If I PR a change, somebody will (usually) merge it pretty quickly.

/ rant

I’ve already written some (rough) type defs for v2 and would be happy to PR them AND keep them updated.