question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Edit message composer has superfluous escaping

See original GitHub issue

Steps to reproduce

  1. Send matrix-react-sdk/res/themes/light/css/_light.scss as message in Element
  2. Hit the up arrow to edit the message

Outcome

What did you expect?

To see the edit message composer appear and prefilled with matrix-react-sdk/res/themes/light/css/_light.scss

What happened instead?

Screen Shot 2022-06-06 at 09 05 50 Screen Shot 2022-06-06 at 13 56 28

Notice the incorrect escaping before the underscore

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

Issue Analytics

  • State:open
  • Created a year ago
  • Comments:14 (12 by maintainers)

github_iconTop GitHub Comments

3reactions
robintowncommented, Jun 7, 2022

It’s not incorrect, just unnecessary, so will mark this as tolerable

1reaction
t3chguycommented, Aug 10, 2022

Yeah so that is just the re-escaping code being naive and not checking if the escaping is necessary

Read more comments on GitHub >

github_iconTop Results From Across the Web

1440835 – Upon draft saving evolution opens redundant warning ...
When I click Discard Changes, composer quits, but my message is saved, ... f) press Escape This opens the dialog to Discard/Continue editing/Save...
Read more >
Override PHP base dependency in composer - Stack Overflow
Is there a way to do a composer install which ignores this dependency? I think it should be safe, as there are only...
Read more >
Remove migration settings in InitialiseSettings.php (Ica5070f0)
Change 631496: Remove migration settings in InitialiseSettings.php · Change metadata · Files and Comments tabs.
Read more >
Deprecate NULL values in Html::escape(), ::decodeEntities ...
This is due to FormattableMarkup replacements being null - those go straight as nulls down to Html::escape() and hence to htmlspecialchars(), ...
Read more >
Composer Help - Genesys Documentation
Voice External Message Blocks ... SCXML Editor Element Not Bound Message ... Composer is an Integrated Development Environment (IDE), ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found