Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Malformed invites seem to kill Riot

See original GitHub issue

Description

I was half-way through trying to get invites to work in Dendrite.

Steps to reproduce

I get kicked to “Something went wrong!” on sync each time after clearing cache. The invite is quite likely malformed but I can’t really tell much more than that at this stage.

Log: sent

Version information

Platform: web

For the web app:

Browser: Safari 13.1 (15609.1.20.111.8)
OS: macOS
URL: dendrite.neilalexander.dev, version 1.5.14-rc.1

Issue Analytics

State:
Created 3 years ago
Comments:10 (4 by maintainers)

Top GitHub Comments

1reaction

turt2livecommented, Apr 22, 2020

It’s an optional field, so definitely shouldn’t crash. If it was required, I’d be more inclined to say that it should crash as non-compliance is not something we should be supporting.

0reactions

neilalexandercommented, Apr 24, 2020

So a Dendrite-originated invite now seems to work:

"invite": {
  "!1jkV639R1h9hr1F4:12D3KooWR4osrER1wbHPQcvS5JHp18jM9souKd1sfeyMpYhdrCCJ": {
    "invite_state": {
      "events": [
        {
          "content": {
            "membership": "invite"
          },
          "sender": "@test:12D3KooWR4osrER1wbHPQcvS5JHp18jM9souKd1sfeyMpYhdrCCJ",
          "state_key": "@test:12D3KooWQrrHKVrSQ3z6qto2oXWHMoaMUykKSp9BVY4s7TdBiXzs",
          "type": "m.room.member"
        },
        {
          "content": {
            "join_rule": "invite"
          },
          "sender": "@test:12D3KooWR4osrER1wbHPQcvS5JHp18jM9souKd1sfeyMpYhdrCCJ",
          "state_key": "",
          "type": "m.room.join_rules"
        },
        {
          "content": {
            "name": "Test Room 30"
          },
          "sender": "@test:12D3KooWR4osrER1wbHPQcvS5JHp18jM9souKd1sfeyMpYhdrCCJ",
          "state_key": "",
          "type": "m.room.name"
        }
      ]
    }
  }
},

However, a Synapse-originated invite still causes the crash:

"invite": {
  "!pevAGtfmcBnQOxophP:synapse.neilalexander.dev": {
    "invite_state": {
      "events": [
        {
          "content": {
            "join_rule": "invite"
          },
          "sender": "@neilalexander:synapse.neilalexander.dev",
          "state_key": "",
          "type": "m.room.join_rules"
        },
        {
          "content": {
            "name": "Test"
          },
          "sender": "@neilalexander:synapse.neilalexander.dev",
          "state_key": "",
          "type": "m.room.name"
        },
        {
          "content": {
            "avatar_url": "mxc://synapse.neilalexander.dev/dxWBvuZXahCtjuztETfMTlPz",
            "displayname": "neilalexander (Synapse)",
            "membership": "join"
          },
          "sender": "@neilalexander:synapse.neilalexander.dev",
          "state_key": "@neilalexander:synapse.neilalexander.dev",
          "type": "m.room.member"
        }
      ]
    }
  }
},

I am guessing that the "membership": "invite" vs "membership": "join" has something to do with it?