question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

New mention UI eats the text of the link

See original GitHub issue

Description

Can’t make a link to a room with a text.

Steps to reproduce

If you write something like that:

Meet me [here](https://riot.im/develop/#/room/#test:matrix.org)

here isn’t shown. Instead it’s the room name that is.

Describe how what happens differs from what you expected.

riot_issue_mention_link

The best solution would be to show the room icon but keep the link text instead of the room name.

Version information

Dev

  • Platform: web

For the web app:

  • Browser: Firefox 54
  • OS: macOS
  • URL: riot.im/develop

Issue Analytics

  • State:open
  • Created 6 years ago
  • Reactions:1
  • Comments:9 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
lampholdercommented, Aug 4, 2017

Pills exist to:

  • help users discover/share new rooms
  • help users have confidence that the link they’re clicking is taking them somewhere they expect to go

We might experiment with more flexible pills in future, but let’s stay simple for now - let’s not let users replace the pill text with their own text.

However, to support @MightyCreak’s usecase, lets render matrix.to links with custom link text as plain ol’ regular links, without any pillification.

0reactions
MightyCreakcommented, Aug 3, 2017

I personally don’t see it as a real threat. On the web, if you’re unsure of the site you’re browsing, you verify the links. It’s the same here but with rooms.

And it’s quite easy to detect a fishing here: if there is a room link in the text and it’s different than the real room link.

But I get devs don’t want to go that way. Thereby I propose to have a different UI for links to room with text. There is already the fact that the text is underlined when there is a text (in my mockup), which remembers that it’s a texted link. Maybe the pill could only be on the left. Leave a regular link on the right, but still saying that this link points to a room.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Apple unveils new ways to share and communicate in iOS 16
iOS 16 introduces iCloud Shared Photo Library to seamlessly share a collection of photos with family, updates to Messages and Mail that help ......
Read more >
Take Part in the New UI Preview for Your JetBrains IDE
While there is lengthy blog post about new UI, there is zero communication about mentioned issue. Thanks for reading this.
Read more >
The Ultimate List of Social Media Acronyms [ELI5, FTW] - Buffer
A complete glossary of social media acronyms and abbreviations - along with definitions - for social media updates and marketing.
Read more >
How do you include hashtags within Twitter share link text?
The tweet text came out as 'I am eating %23branstonpickel right now' literally including %23 instead of converting it to a hash. Sorry...
Read more >
4 Types of Memory Leaks in JavaScript and How to Get Rid Of ...
getElementById('text') }; function doStuff() { image.src = 'http://some.url/image'; button.click() ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found