question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Users may try to redact their own join event, causing confusing behaviour

See original GitHub issue

Steps to reproduce

In the Discord world, it can be common to delete the message signalling that you’ve joined a server in order to hide the fact that you joined. I am not sure why Discord allows this, but that is the case.

Users coming from this world may try to do the same in Element, by redacting their own join event. Doing so will only strip any keys other than membership from the event’s content, meaning:

  1. The event does not leave the timeline.
  2. The user’s displayname and avatar disappear.

Additionally, the redaction does not appear in the timeline, which I found odd.

I don’t propose that this be prevented at the spec level (some people may want to remove their displayname and avatar from a room - though arguably this could just as easily be done by sending another join event). Instead, I think Element should either prevent it in the UI at the client level (don’t show the option) or otherwise warn the user when they’re about to do it. Though that may be a bit complicated to describe in plain words.

Outcome

What did you expect?

To not see users redacting their own join events and then getting confused and thinking that there’s a bug.

What happened instead?

The opposite.

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
t3chguycommented, Feb 15, 2022

It still appears for me, “show hidden events” or no. Doing a clear cache and reload did not help.

I misread it in the negative, it being still visible is very much intentional and done as a fix of https://github.com/vector-im/element-web/issues/20959

0reactions
anoadragon453commented, Feb 15, 2022

The event does not leave the timeline.

This is no longer true

It still appears for me, “show hidden events” or no. Doing a clear cache and reload did not help.

image

The contents of the join event are:

{
  "content": {
    "membership": "join"
  },
  "origin_server_ts": 1644811735905,
  "sender": "@hinkii:matrix.org",
  "state_key": "@hinkii:matrix.org",
  "type": "m.room.member",
  "unsigned": {
    "redacted_by": "$4Z4WbSxw-1guFBSubxXRzzLV2wFaAbGea7M0UmaRGp4",
    "redacted_because": {
      "content": {},
      "origin_server_ts": 1644811784569,
      "redacts": "$LUM_4zL1vEgVUbaaYiJcY34ZMbDcVeCeaqvHLsfXxTQ",
      "sender": "@hinkii:matrix.org",
      "type": "m.room.redaction",
      "unsigned": {},
      "event_id": "$4Z4WbSxw-1guFBSubxXRzzLV2wFaAbGea7M0UmaRGp4",
      "room_id": "!redacted:matrix.org"
    }
  },
  "event_id": "$LUM_4zL1vEgVUbaaYiJcY34ZMbDcVeCeaqvHLsfXxTQ",
  "room_id": "!redacted:matrix.org"
}

and the redaction:

{
    "content": {},
    "origin_server_ts": 1644811784569,
    "redacts": "$LUM_4zL1vEgVUbaaYiJcY34ZMbDcVeCeaqvHLsfXxTQ",
    "room_id": "!redacted:matrix.org",
    "sender": "@hinkii:matrix.org",
    "type": "m.room.redaction",
    "unsigned": {},
    "event_id": "$4Z4WbSxw-1guFBSubxXRzzLV2wFaAbGea7M0UmaRGp4",
    "user_id": "@hinkii:matrix.org"
}
Read more comments on GitHub >

github_iconTop Results From Across the Web

Redacting ticket content in the Zendesk Agent Workspace
When redacting a ticket, the underlying conversation is not edited on the social messaging platform and third-party integrations. It is redacted ...
Read more >
Moderation in Matrix - Matrix.org
Matrix implements the concept of redactions (called 'remove message' in Element's UI), which allows a moderator to send a 'redaction event' to a...
Read more >
Spam Policies for Google Web Search | Documentation
The spam policies detail the behaviors and tactics that can lead to a page or an entire site being ranked lower or completely...
Read more >
Overview of the Privacy Act: 2020 Edition - Department of Justice
There are twelve exceptions to this general rule. A. The “No Disclosure without Consent” Rule. “No agency shall disclose any record which is...
Read more >
Confidentiality of Substance Use Disorder Patient Records
In turn, the non-part 2 provider can then carry out her own ... Several commenters said the proposed change would cause confusion for ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found