Cutting board recipes cannot use a non-vanilla ingredient serializer for tools
See original GitHub issueDescription
This is something I noticed looking through your code while working on a pull request that coincidentally fixes this very issue (see #143).
The serializer for cutting recipes applies a special case check to allow the type
key in the tool
ingredient to define tool types. Apparently forge already uses the same type
key to allow custom ingredients serializers to be used.
Steps to reproduce: Create a datapack which adds a cutting board recipe with uses a non-vanilla ingredient serializer for the tool ingredient, for example:
"tool": {
"type": "forge:nbt",
"item": "minecraft:stick",
"count": 2
}
The recipe fails to load, because the recipe serializer tries to get/create a tool type called forge:nbt
, which is not a valid tool type name.
Mod list: Farmer’s Delight 0.3.1-1.16.3+
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (4 by maintainers)
Top Results From Across the Web
Ingredient.fromJson in a custom recipe class results ... - GitHub
Use Ingredient.fromJson within any non-vanilla recipe Serializer to try to create an Ingredient from JSON. Enter game and use JEI/recipe book to ...
Read more >Make Your Own Cutting Board Finish: Simple Recipe and ...
Learn how to make this simple and inexpensive cutting board finish — plus other uses in your woodshop.
Read more >Custom Recipes/1.16 - Forge Community Wiki - Gemwire
A custom recipe category indicates that recipes of that type will be used in that particular context. IRecipeSerializer : The serializer ...
Read more >35 Possibilities for Dinner on a Cutting Board | FN Dish
Pulling ingredients from the pantry, fridge and freezer, then loading them onto the cutting board is equal parts handy (chop those peppers right...
Read more >Wood Cutting Board Care - Life-n-Reflection
Use these Easy 4 Steps to Wood Cutting Board Care and Utensils Care Too with a Lemon Fresh Spoon Butter Recipe to Extend...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Good catch. As stated on your PR, I’ll wait before merging this fix, just to decide whether it warrants a 0.4.0 (since it’s technically a breaking change), and whether to release the current minor updates as a dot release.
Woops, I merged the PR and forgot to close this issue. My bad. Thanks for the fix!