Tests fail under Node version 7
See original GitHub issue(Both @domoritz and I got the same problem)
Note that despite this error, we can still serve local web server or link it to vega editor seamlessly.
npm ERR! Darwin 16.1.0
npm ERR! argv "/usr/local/Cellar/node/5.0.0/bin/node" "/usr/local/bin/npm" "run" "test"
npm ERR! node v5.0.0
npm ERR! npm v3.3.9
npm ERR! code ELIFECYCLE
npm ERR! vega@3.0.0-beta.5 test: `TZ=America/Los_Angeles tape 'test/**/*-test.js' && eslint index.js src test`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the vega@3.0.0-beta.5 test script 'TZ=America/Los_Angeles tape 'test/**/*-test.js' && eslint index.js src test'.
npm ERR! This is most likely a problem with the vega package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! TZ=America/Los_Angeles tape 'test/**/*-test.js' && eslint index.js src test
npm ERR! You can get their info via:
npm ERR! npm owner ls vega
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /Users/kanitw/Documents/_code/_idl/_visrec/vega3/npm-debug.log
npm ERR! Darwin 16.1.0
npm ERR! argv "/usr/local/Cellar/node/5.0.0/bin/node" "/usr/local/bin/npm" "run" "build"
npm ERR! node v5.0.0
npm ERR! npm v3.3.9
npm ERR! code ELIFECYCLE
npm ERR! vega@3.0.0-beta.5 build: `npm run test && uglifyjs build/vega.js -c -m -o build/vega.min.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the vega@3.0.0-beta.5 build script 'npm run test && uglifyjs build/vega.js -c -m -o build/vega.min.js'.
npm ERR! This is most likely a problem with the vega package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! npm run test && uglifyjs build/vega.js -c -m -o build/vega.min.js
npm ERR! You can get their info via:
npm ERR! npm owner ls vega
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /Users/kanitw/Documents/_code/_idl/_visrec/vega3/npm-debug.log
npm ERR! Darwin 16.1.0
npm ERR! argv "/usr/local/Cellar/node/5.0.0/bin/node" "/usr/local/bin/npm" "install"
npm ERR! node v5.0.0
npm ERR! npm v3.3.9
npm ERR! code ELIFECYCLE
npm ERR! vega@3.0.0-beta.5 prepublish: `npm run build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the vega@3.0.0-beta.5 prepublish script 'npm run build'.
npm ERR! This is most likely a problem with the vega package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! npm run build
npm ERR! You can get their info via:
npm ERR! npm owner ls vega
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /Users/kanitw/Documents/_code/_idl/_visrec/vega3/npm-debug.log
Issue Analytics
- State:
- Created 7 years ago
- Comments:14 (13 by maintainers)
Top Results From Across the Web
Tests fail only locally with latest node/npm versions #1774
Some async tests systematically fail after a node/npm upgrade, only on my machine. I tried re-installing node with Homebrew, then removed it ...
Read more >Cannot get node js test to fail - Stack Overflow
You have correctly identified the issue and passing done to the outermost function and calling it in the http.get() function causes the test...
Read more >Node.js v19.3.0 Documentation
Asserts that the function fn does not throw an error. Using assert.doesNotThrow() is actually not useful because there is no benefit in catching...
Read more >Testing Error Handling in node.js | by Lars Trieloff
Testing Error Handling in node.js · 1. Don't let yourself get away with less than 100% · 2. Always assert the exception ·...
Read more >T213944 Jenkins jobs for npm-test fail on project with deps on ...
7 there. Mainly because Most jessie/node6 jobs already have py27 (we've been using node-gyp in dev dependencies for years without issue). But ...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Test code, absolutely. I would normally just do “closeTo” but that’s not so handy for testing SVG path strings, scenegraph JSON, etc. Right now I’m thinking we might monkey patch Math.atan2 directly, then restore after tests complete. Better ideas welcomed!
As of 0b4221e05670e427f2fb895acc522cabea46cb4a, we’re now node 7 compliant, and have dropped explicit support for node 0.12. (Vega, but not the test suite, should still work under 0.12.)
After more investigation, I found problems beyond
Math.atan2
. So I bit the bullet and added a new specialized “deepEquals” operator (with error tolerance for numbers) for Vega scenegraphs and SVG paths. Upon reflection I decided this was the cleaner, more future-proof (and more time-efficient) route. These are exported as the newsceneEqual
andpathEqual
utilities invega-scenegraph
.