Email plugin EmailEventListener('order-confirmation') missed some usefull information `shippingMethod.name, productVariant.featureAsset` ..
See original GitHub issueDescribe the bug
for plugin-email
we want to customized EmailEventListener('order-confirmation')
but it missed as below usefull information
- shippingMethod.name, description cause of it has type
LocaleString
need to join table.
for (const line of context.event.order.shippingLines || []) {
let shippingMethod: ShippingMethod | undefined;
if (!line.shippingMethod && line.shippingMethodId) {
shippingMethod = await context.injector
.get(TransactionalConnection)
.getRepository(ShippingMethod)
.findOne(line.shippingMethodId);
} else if (line.shippingMethod) {
shippingMethod = line.shippingMethod;
}
if (shippingMethod) {
shippingMethods.push(shippingMethod);
}
}
-
.setTemplateVars(event => ({ order: event.order, shippingMethods: event.data.shippingMethods }))
theorder.line.productVariant.featuredAsset
has missed also. -
.loadData(async ({ event, injector }) => {
should be also supportLanguage
configuration for diferent language locale.
Expected behavior none
Environment (please complete the following information):
- @vendure/core version: 1.4.4
- Nodejs version 14.x+
- Database (mysql/postgres etc): mysql
Additional context Add any other context about the problem here.
Issue Analytics
- State:
- Created 2 years ago
- Comments:9 (4 by maintainers)
Top Results From Across the Web
No results found
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Oh yeah, the system I use to generate the changelog always says “closes #1234” even if the commit only actually includes the text “Relates to #1234”. I can see how the confusion came about.
BTW if we configuration asset-plugin as
the
event.order.lines[0].featuredAsset
should return me full path http url but now only return me