Stock movement is doubled

Describe the bug We started tracking inventory and found out that each completed order lowered stock by double the size of actual order contents. I believe this piece of code is to blame: in order-state-machine.ts

    private async onTransitionEnd(fromState: OrderState, toState: OrderState, data: OrderTransitionData) {
        if (toState === 'PaymentAuthorized' || toState === 'PaymentSettled') {
            data.order.active = false;
            data.order.orderPlacedAt = new Date();
            await this.stockMovementService.createSalesForOrder(data.ctx, data.order);
            await this.promotionService.addPromotionsToOrder(data.ctx, data.order);
        }

To Reproduce Steps to reproduce the behavior:

• Have an order flow that uses both PaymentAuthroized and PaymentSettled states.
• Track inventory
• Make an order and transition it through these both states
• notice that inventory of those products were lowered by double the amount

Expected behavior Should lower the stock exactly to the order. We should be able to define at which point of an order flow should the inventory movement take place. Also this code should take in account the direction of the transition - if we revert state transition (e.g. “Processing” to “PaymentSettled” it should not do stock movement neither.)

Environment (please complete the following information):

• @vendure/core version: .16.3
• Database (mysql/postgres etc): postgres

[michaelbromley]

orderPlacedAt is added to the GraphQL type in my local next branch already, and will be in 0.17.0

[chladog]

Great! This way we’ll have good default behavior, but also will have option to implement advanced one.

BTW the property I see here orderPlacedAt is on Order entity, but is missing in graphql Object type. Could we make it accessible on both admin-api and shop-api? It’s handy property for data analytics (e.g. we want to know how many orders been placed in between some dates.). And on shop-api handy for making “Order history” page where will be date of placing the order, not creation. Should I make new feature request for this?