Unusable images in admin-ui in case of custom asset server
See original GitHub issueDescribe the bug If you use custom asset strategies or/and custom asset server where you don’t need different set of image thumbnails, you will get something like this over the admin-ui:
It can be fixed by applying following attributes to image:
object-fit: cover;
width: 100%;
height: 100%;
I’m not good at frontend, but seems object-position attribute can be also helpful to implement focal point.
To Reproduce Steps to reproduce the behavior:
- Implement asset strategies to avoid local thumbnail creation.
- Go to admin-ui
- Go to product list
- See error
Expected behavior Correct size of asset images
Environment (please complete the following information):
- @vendure/core version: 1.5.0
- Nodejs version 14
- Database (mysql/postgres etc): postgres
Issue Analytics
- State:
- Created a year ago
- Comments:6 (5 by maintainers)
Top Results From Across the Web
Manage replay assets with the asset manager
Manage replay assets with the asset manager ; Native Images · From the menu bar, select user name > Admin and then select...
Read more >Enable serving of images, stylesheets, and JavaScripts from ...
I Enabled serving of images, stylesheets, and JavaScripts from an asset serve by turning this configuration from production.rb
Read more >Limitations and known issues for Watson Knowledge ... - IBM
Artifacts are not synced to Information Assets view; Custom category roles ... Connection might not be usable in discovery after updating the password...
Read more >Portfolio Client Guide - Extensis
These engines return identifying characteristics for images of artworks in your catalog. ... We now support running Portfolio on Windows Server 2019.
Read more >Admin UI Guide - ExtraHop Documentation
The following steps show you how to configure the ExtraHop system to send audit log data to a remote syslog server. Log in...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@michaelbromley I also cannot reproduce it, sorry for wasting valuable time… Not sure what went wrong on my end, I believe I was pretty thorough with deleting generated admin ui files.
Anyhow, this issue can be closed! 🥇
I cannot reproduce what you see @martijnvdbrug on the current master branch. Here’s a screenshot where you can see the intrinsic size of the image is 1600x1067, yet the
.content-area img
styling is forcing it to fit in its container.