5bc8e0b (on canary) breaks <esc> key

• I am on the latest Hyper.app version

• I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: Linux

• Hyper.app version: 6f96d9f (latest commit on canary branch)

• Link of a Gist with the contents of your .hyper.js: N/A

• Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): N/A

• The issue is reproducible in vanilla Hyper.app: yes

Issue

Commit 5bc8e0b introduces in each of the app/keymaps files the properties editor:search and editor:search-close. The value for the latter, "esc", is unfortunate because it’s global, is an extremely relevant key for vim users, and also factors into terminal shortcuts (at least when using bash).

Might it be possible to enable editor:search-close only when actually searching? This would keep it from interfering when not using the search feature. Alternatively, might a different key sequence be used (such as shift+esc)?

[admosity]

This comment got my esc key working again on the canary channel:

https://github.com/vercel/hyper/issues/3217#issuecomment-646773120

Adding this to the config

  keymaps: {
    'editor:break': 'esc',
  },

[egst]

editor:break does ctrl+c, but I think ctrl+[ would be more useful. In Vim, esc and ctrl+[ are equivalent, while ctrl+c is slightly diferent. It’s not a major problem in Vim but it definitely is a problem in a shell with Vi mode as ctrl+c has a completely different meaning in this context. Mapping esc to ctrl+c makes it impossible to switch to the command mode in a vi mode shell with the esc key. Is there currently any way to map esc to ctrl+[?