Add support for underline ANSI escape code in WebGL Renderer
See original GitHub issue- I am on the latest Hyper.app version
- I have searched the issues of this repo and believe that this is not a duplicate Comment: I believe it is not duplicate of an open issue, see below.
- OS version and name: MacOS Mojave 10.14.5
- Hyper.app version: 3.0.2
- Link of a Gist with the contents of your .hyper.js: N/A
- Relevant information from devtools : N/A
- The issue is reproducible in vanilla Hyper.app: yes
Issue
This is a continuation of the closed issue: https://github.com/zeit/hyper/issues/3194. Albeit the old issue being closed the problem still exists and is reproducible.
Currently Hyper does not display text decorated with ANSI escape code 4m
for underline correctly. I am not sure if this is a bug or feature request. However, a commenter from the old issue suggests this has been supported before and hence, should be classified as a bug. See https://github.com/zeit/hyper/issues/3194#issuecomment-456966115
Reproduce
Run
echo -e "\033[4mhyper\033[m"
Expected result
The output gets underlined. See screenshot from iterm2.
Actual result
The output does not get underlined. See screenshot from Hyper.
Issue Analytics
- State:
- Created 4 years ago
- Reactions:3
- Comments:8 (2 by maintainers)
Top Results From Across the Web
Build your own Command Line with ANSI escape codes
The most basic Ansi escape codes are those involved in rendering text. These let you add decorations like Colors, Background Colors or other ......
Read more >Terminal Appearance in Visual Studio Code
Visual Studio Code's integrated terminal allows customizing its appearance in various ways.
Read more >Rendering terminal ansi escape sequence in Blessed lib
I spent 8 month's working on a portfolio project believing that I could render terminal hyperlinks in the node library called Blessed.
Read more >How Warp Works
Warp is a new high-performance terminal built entirely in Rust that makes you and your team more productive and the CLI easier to...
Read more >ANSI escape code - Wikipedia
ANSI escape sequences are a standard for in-band signaling to control cursor location, color, font styling, and other options on video text terminals...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I accidentally found a big hint. It looks like the
webGLRenderer
is causing problems. In fact, if I disablewebGLRenderer
in.hyper.js
the underlines appear. SeeWorking in v3.1.3