Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Electron v1.6.x compatibility

See original GitHub issue

I’m on MacOS

Master ~is currently~ was broken because of electron upgrade in this commit

HTR:

Checkout master and resintall dependencies (rm -Rf node_modules && yarn)
Launch Hyper (npm run dev and npm run app)
Open DevTools
Hit ctrl key

An exception occurs: Closure Exception

It sounds crazy because code (and const cache declaration) is ok. I have checked with electron v1.4.16 and everything is allright!

I studied this issue in depth and I found a closure problem with isAccelerator function. With v1.4.16: capture d ecran 2017-04-09 a 10 24 06

But with 1.6.6 a closure (with cache variable) is missing: capture d ecran 2017-04-09 a 20 48 38

I don’t know yet if it is a V8 issue (I strongly doubt that). But I found an Electron related issue: webpack use some eval

If this issue is confirmed, due to its nature, we can suppose there is another issues with this same scope cause. I would recommend to stick to stable release channel of electron (v1.4.16).

Issue Analytics

State:
Created 6 years ago
Comments:9 (6 by maintainers)

Top GitHub Comments

1reaction

chaboucommented, May 21, 2017

Great ! Fixed by #1848

1reaction

albinekbcommented, May 20, 2017

@MartyGentillon check #1848 👌

Top Results From Across the Web

Complete and up-to-date info about every release of Electron

Tag Published Prerelease Module Version Node Chrome v24.0.0‑nightly.20221216 2022‑12‑16 yes 114 18.12.1 110.0.5451.0 v24.0.0‑nightly.20221215 2022‑12‑15 yes 114 18.12.1 110.0.5451.0 v24.0.0‑nightly.20221214 2022‑12‑14 yes 114 18.12.1 110.0.5451.0

electron-releases - npm

Complete and up-to-date info about every release of Electron. Latest version: 3.1171.0, last published: 2 months ago.

Electron release notes

Sunsetting Windows 7/8/8.1 Electron will be ending support for Windows 7/8/8.1 after version 22. x.y following Chromium's plan to end support. Older versions ......

Electron (software framework) - Wikipedia

Electron frequently releases new major versions along every other Chromium release. The latest three stable version are support by the Electron team.

Electron-edge-js NPM

Compatible with. Electron 6.x - Node.js v12.4.0. ... Electron 14.x - Node.js v14.17.0; Electron 15.x - Node.js v16.5.0; Electron 16.x - Node.js v16.9.1 ......