Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Legal comments are no longer kept in bundle

See original GitHub issue

Bug report

Describe the bug

Previous versions of Next.js (at lest v7.x) included legal comments in the commons.js bundle:

(window.webpackJsonp=window.webpackJsonp||[]).push([[0], /* ... */
/*!
 * The buffer module from node.js, for the browser.
 *
 * @author   Feross Aboukhadijeh <feross@feross.org> <http://feross.org>
 * @license  MIT
 */
...

In v9.0.x and v9.2.x, those legal comments are now stripped out:

(window.webpackJsonp=window.webpackJsonp||[]).push([[0] /* ... */

To Reproduce

next build && next export
Serve files locally (e.g. npx http-serve out -p 3000)
Browse generated assets in the devtools (commons-xxxx.js in particular).

Expected behavior

Legal comments should be kept in the bundle, and I believe that’s the default webpack configuration.

Screenshots

See snippets above.

System information

OS: macOS
Browser (if applies) Chrome v79
Version of Next.js: v9.2 (vs v7.x)

Thanks for looking into this!

Issue Analytics

State:
Created 4 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

3reactions

paulcnicholscommented, Feb 19, 2020

Is there a best practice about where to put this license file or how to make it discoverable to anyone concerned?

1reaction

timneutkenscommented, Jan 19, 2020

We mirror create-react-app’s behavior here.

The comments are of no actual use in production bundles as the original code is not preserved (minified) and the comment as is covers the full file because everything is minified, which is incorrect. Instead you should compile a list of license files from all npm deps that you have, not just the ones with comments. You can use something like: https://www.npmjs.com/package/npm-license-crawler.