Router.push not causing page mount when going to same page with different query string

When using Router.push to route to the same page but with a different query string value the page is not remounted. Instead, both getInitialProps and componentWillReceiveProps are executed. Is this the intended behavior?

• I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

I would expect the current page component to unmount (componentWillUnmount should fire) and the new page to mount (componentDidMount should fire). If people want to shallow route they can use the Router shallow:true option.

Current Behavior

Steps to Reproduce (for bugs)

import { Component } from 'react';
import Router from 'next/router';

class PageTest extends Component {

  constructor(props) {
    super(props);
    this.state = {};
    this.goToPage = this.goToPage.bind(this);
  }

  static async getInitialProps({ query }){
    console.log('getInitialProps');
    return {
      pageId: query.pageId 
    }
  }

  componentWillReceiveProps(nextProps){
    console.log('componentWillReceiveProps', nextProps);
  }

  componentDidMount(){
    console.log('componentDidMount');
  }

  componentWillUnmount(){
    console.log('componentWillUnmount');
  }

  goToPage(e){
    e.preventDefault();

    const { pageId } = this.props;
    const nextPageId = pageId === 'a' ? 'b' : 'a';

    Router.push(
      `/page-test?pageId=${nextPageId}`,
      `/page-test/${nextPageId}`,
      //{ shallow: false } // Doesn't do anything
    );
  }

  render() {
    return (
      <div>
        <a href="#" onClick={this.goToPage}>Go to other page</a>
      </div>
    );
  }
}

export default PageTest;

Context

Your Environment

Tech	Version
next	3.0.6
node	8.1.4
OS	OSX
browser	Chrome
etc

[aulneau]

@arunoda @gragland I fixed my issues by adding a unique key to the component, it will cause it to remount 😃

[arunoda]

This is not a bad thing. This is a feature. This is the only you could do animations and changes view without re-rendering the page.