Shallow routing example throws TypeError: Cannot read property 'auth' of null

Bug report

I’m not sure this is a bug, but it throws an error and it probably shouldn’t.

Describe the bug

Shallow routing following the docs throws TypeError:

Unhandled Rejection (TypeError): Cannot read property 'auth' of null

To Reproduce

Clone repo and run:

https://github.com/tgdn/nextjs-shallow-typeerror/

Expected behavior

Error should not be thrown.

System information

• OS: macOS
• Version of Next.js: tried both 9.3.2 and 9.3.3

[gndelia]

I came across the same problem in the docs and I found this issue, so I created a small PR to update the docs 😃

[HassenHichri]

@tgdn @jamesmosier I came across the same issue while following the docs. I think the problem comes from here where as is initiated to url (typeof null return always object), and because passing null is different from undefined for the behaviour of default parameter value(see here) , as parameter doesn’t get url value when initiated to null.

@timneutkens I can see 2 possibilities here:

• update the docs to use undefined instead of null: router.push('/?counter=10', undefined, { shallow: true })
• add null check for as parameter in push function (maybe also in replace function), something like this in router.ts:

push(url: Url, as: Url = url, options = {}) {
    return this.change('pushState', url, as === null ? url : as, options)
  }

I would be happy to submit a PR with either of these solutions 😊