question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Mention drawbacks in the readme

See original GitHub issue

As I understand this is a rebranding of the enclose module? Would love to know how this happened btw.

But, in original documentation, here – http://enclosejs.com/#compilation-srsly it says that resulting binary will be at least 2x slower, is that still the case? And if so, can you mention that in the readme? It would be better I think to also document how this sort of measurements was performed.

As well as any other possible drawbacks, besides performance and size

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:9
  • Comments:8 (5 by maintainers)

github_iconTop GitHub Comments

5reactions
igorklopovcommented, May 3, 2017

@simast Yes!

1reaction
firraecommented, May 5, 2017

Hi there,

So I added --options ignition,turbo,turbo-from-bytecode to the build I just did and got the following error:

buffer.js:12
    super(arg1, arg2, arg3);
    ^

ReferenceError: this is not defined
    at FastBuffer (buffer.js:12:5)
    at createUnsafeBuffer (buffer.js:38:10)
    at allocate (buffer.js:190:12)
    at Function.Buffer.allocUnsafe (buffer.js:153:10)
    at Function.Buffer.concat (buffer.js:322:23)
    at Socket.<anonymous> ([eval]:5:20)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:189:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at Socket.Readable.push (_stream_readable.js:134:10)
    at Pipe.onread (net.js:551:20)
> Error! Error: Was not able to compile for '{"nodeRange":"node7","platform":"linux","arch":"x64","output":"/Users/steven.lambe/iot/index-linux","forceBuild":false,"fabricator":{"nodeRange":"node7","platform":"macos","arch":"x64","forceBuild":false,"binaryPath":"/Users/steven.lambe/.pkg-cache/v1.9/fetched-v7.6.0-macos-x64"},"binaryPath":"/Users/steven.lambe/.pkg-cache/v1.9/fetched-v7.6.0-linux-x64","slash":"/"}'
    at Socket.<anonymous> (/usr/local/lib/node_modules/pkg/lib-es5/producer.js:46:25)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at onwriteError (_stream_writable.js:341:10)
    at onwrite (_stream_writable.js:359:5)
    at fireErrorCallbacks (net.js:480:13)
    at Socket._destroy (net.js:521:3)
    at WriteWrap.afterWrite [as oncomplete] (net.js:815:10)

Once I removed turbo-from-bytecode though it seems to work. Am I missing something?

Building on Mac, targeting Mac, Linux, and Windows x64 with Node 7.

Read more comments on GitHub >

github_iconTop Results From Across the Web

mentions do not render in README.md #209 - github/markup
Advantages : mentioning users in a README allows readers to immediately view the user, via click or hover over, which is very convenient;...
Read more >
README | Developer Experience Knowledge Base
Common Pitfalls of the README. It is not being updated regularly. It is too short or too long. The maintainer is not mentioned...
Read more >
How to Write a Good README File for Your GitHub Project
A good one takes advantage of the opportunity to explain and showcase: What your application does,; Why you used the technologies you used, ......
Read more >
How to write a good README for your GitHub project?
We should describe in an interesting manner what's the project aim, and what problems does a given application solve. Two or three sentences...
Read more >
Essential Sections for Better Documentation of a README ...
... and essential things about README files, as well as the ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found