Random call stack size exceeded in binaries complied with node v12.2.0

Thanks for updating pkg to support node v12!

It seems that there is a weird bug causing random Maximum call stack size exceeded errors ONLY in binaries complied by pkg targeting node v12.2.0:

	Binary compiled by pkg	Run directly through node
node v10.15.3	✅	✅
node v12.2.0	Maximum call stack size exceeded	✅

(Tested on Linux / CentOS 7)

Unfortunately, the original code is part of a proprietary software so I could not post it here. But since it does not deal with files, I’m pretty sure the issue is not related to the snapshot file system.

Here are some stack trace samples, seems fully random, the only thing in common is the RangeError: Maximum call stack size exceeded:

06:25:30 [22016]: events.js:196
06:25:30 [22016]: Reflect.apply(handler, this, args);
06:25:30 [22016]: ^
06:25:30 [22016]: RangeError: Maximum call stack size exceeded
06:25:30 [22016]: at Object.emit (events.js:196:13)
06:25:30 [22016]: at endReadableNT (_stream_readable.js:1130:12)
06:25:30 [22016]: at processTicksAndRejections (internal/process/task_queues.js:84:9)

06:07:11 [11185]: _stream_transform.js:140
06:07:11 [11185]: this._flush((er, data) => {
06:07:11 [11185]: ^
06:07:11 [11185]: RangeError: Maximum call stack size exceeded
06:07:11 [11185]: at String.replace (<anonymous>)
06:07:11 [11185]: at Object.prefinish (_stream_transform.js:140:10)
06:07:11 [11185]: at Object.emit (events.js:196:13)

06:18:41 [18060]: internal/timers.js:531
06:18:41 [18060]: timer._onTimeout();
06:18:41 [18060]: ^
06:18:41 [18060]: RangeError: Maximum call stack size exceeded
06:18:41 [18060]: at listOnTimeout (internal/timers.js:531:17)
06:18:41 [18060]: at processTimers (internal/timers.js:475:7)

[igorklopov]

Fixed in 4.4.1. Please try

[OneBitAhead]

Same error occurs on Linux / Ubuntu.

Indeed it seems to be VERY random. Here are some of my stack traces:

/snapshot/oba-core/node_modules/cron/lib/cron.js:562
			this._callbacks[i].call(this.context, this.onComplete);
			                   ^

RangeError: Maximum call stack size exceeded
    at CronJob.fireOnTick (/snapshot/oba-core/node_modules/cron/lib/cron.js:562:23)
    at Timeout.callbackWrapper [as _onTimeout] (/snapshot/oba-core/node_modules/cron/lib/cron.js:629:10)
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)

events.js:196
    Reflect.apply(handler, this, args);
            ^

RangeError: Maximum call stack size exceeded
    at process.emit (events.js:196:13)
    at processPromiseRejections (internal/process/promises.js:165:18)
    at processTicksAndRejections (internal/process/task_queues.js:90:32)

Besides: You do a great job with pkg!