asFindQuery() returns wrong builder for patchAndFetchById() operations

I am using asFindQuery() to get the affected items in a static beforeUpdate() model hook that gets called when patchAndFetchById() is executed.

In this situation, asFindQuery() does not return a query that only selects the affected model items, it returns a query without a where clause, returning all model items of the given model class.

According to the docs, it should only return the model item with the given id?

[koskimas]

I’ll start working on this now.

[fvinogradov]

I’m facing the same issue with updateAndFetchById. In code below asFindQuery executing returns all rows from DB:

class CampaignModel extends Model {
  static async beforeUpdate(ops) {
    await super.beforeUpdate(ops);
    const { asFindQuery, inputItems } = ops;
    const foundCampaigns = await asFindQuery().select('id', 'status');
  }
}

await CampaignModel
  .query()
  .updateAndFetchById(
    id,
    {
      status: 'PROCESSING',
    },
  );

As a temporal solution, for this model with beforeUpdate hook I replaced updateAndFetchById with

await CampaignModel
  .query()
  .update(
    {
      status: 'PROCESSING',
    },
  )
  .where({ id });