Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improve custom layer compatibility

See original GitHub issue

Background

For #2264 mapbox custom layer integration, it introduces an external GL context for mapbox. It’s exciting, but for other map engines like maptalks canvas in the GL context created externally is not rendered correctly，and I’ve found some reasons：

Externally created temporary canvas does not update clientWidth and clientHeight, so I modified the following two places. https://github.com/uber/deck.gl/blob/4779b1040c6379c713f1a8b2d6b688b2b2909982/modules/core/src/lib/deck.js#L358 https://github.com/uber/deck.gl/blob/4779b1040c6379c713f1a8b2d6b688b2b2909982/modules/core/src/lib/draw-layers.js#L40

clientWidth => width clientHeight => height
This is the examples maptalks.deckgl

animation2

So I think the above modifications will have better compatibility.

To Do List

Add label and assign to milestone
Coding
Doc update
Whats new update
Test

Issue Analytics

State:
Created 5 years ago
Comments:5 (2 by maintainers)

Top GitHub Comments

1reaction

Pessimistresscommented, Jan 2, 2019

Fix published in deck.gl@6.3.3

0reactions

1chanducommented, Dec 5, 2018

Resolved by #2405

Top Results From Across the Web

Improve custom layer compatibility · Issue #2296

Background For #2264 mapbox custom layer integration, it introduces an external GL context for mapbox. It's exciting, but for other map ...

Making new Layers and Models via subclassing

However, for some advanced custom layers, it can become impractical to separate the state creation and computation.

Keras custom layer input shape compatibility problem

I'm trying to write a custom activation layer in keras. The problem is, I've tried to do it with a sigmoid and with...

Lambda layers for custom models

In another article, we have already talked about custom layers and how these tools allow us to create completely original models suitable ...

Check Custom Layer Validity - MATLAB & Simulink

The function checks layers for validity, GPU compatibility, correctly defined gradients, and code generation compatibility. To check that a layer is valid, ...