ATOMIC_REQUESTS and async views

First of all, thank you very much for your work on this project. I sincerely hope that you and your family are doing well and I sincerely pray for the resolution of the conflict in Ukraine.

Describe the bug I’m getting a RuntimeError on my django ninja async views when ATOMIC_REQUESTS is true

Versions

• Python version: 3.10
• Django version: 4.0.3
• Django-Ninja version: 0.17.0

# settings.py
DATABASES["default"]["ATOMIC_REQUESTS"] = True

# api.py


@transaction.non_atomic_requests
@router.post("/flight-hotel-search", response=FlightHotelSearchResult)
async def flight_hotel_search(request:HttpRequest, criteria: FlightHotelSearchCriteria):
  # there is zero database call done by me in this view
  ...



# Error
# RuntimeError: You cannot use ATOMIC_REQUESTS with async views.

[bencleary]

Ah that makes sense, yeah its one of the big gotchas of async and Django, until the ORM is finished its rough to get it all playing together.

[Tobi-De]

I could just be missing a few things, are these async call’s external services? or the database? Also what is your need for the atomic requests?

yes, they were suppose to be async http call to external services. The atomic requests is on the entire project. I have this setting on by default on all of my projects. I plan to use async code in only one view anyway, it doesn’t make sense to me to disable atomic requests for the sole purpose of making one specific view work