The images in /dist/assets are not cached

I changed the SVG image in the demo to PNG, and then placed it in /src/assets. This image will not be displayed offline

I tried to write ['*.png'] in includeAssets, it didn’t seem to work

I uploaded the demo code here

[userquin]

@akirarika both are equivalent, the main diference is that with your solution, you sould take care including all assets. includeAssets will add the result on [workbox/injectManifest].additionalManifestEntries instead manipulating [workbox/injectManifest].globPatterns: https://github.com/antfu/vite-plugin-pwa/blob/main/src/assets.ts#L32, https://github.com/antfu/vite-plugin-pwa/blob/main/src/assets.ts#L58 and https://github.com/antfu/vite-plugin-pwa/blob/main/src/assets.ts#L101

[mykwillis]

Regarding the warning message, I see now my confusion.

This note:

If you configure globPatterns on workbox or injectManifest plugin option, you MUST include all your assets patterns: globPatterns will be used by workbox-build to match files on dist folder. By default, globPatterns will be **.{js,css,html}: workbox will use glob primer

Might be more clear if it said:

If you provide a value for either workbox.globPatterns (when using generateSW strategy) or for injectManifest.globPatterns (when using injectManifest strategy), you MUST include all of…

Sorry for my confusion on that.