Circular dependency warning despite dynamic import

Describe the bug

Suppose I have two files like these:

// one.mjs
console.log("Hello from one.mjs");

setTimeout(() => {
	import("./two.mjs");
}, 500);

// two.mjs
import "./one.mjs";

console.log("Hello from two.mjs");

When I ssrLoadModule("./one.mjs"), I get the following output:

Hello from one.mjs
Hello from one.mjs
Hello from two.mjs
Circular dependency: one.mjs -> /two.mjs -> /one.mjs -> /two.mjs

That is, one.mjs is evaluated twice before two.mjs is evaluated and I get a circular dependency warning. I’m aware of the limitations and I know there is a pull request to allow circular dependencies in SSR.

But in this case I think the evaluation of one.mjs should have been completed before two.mjs is imported due to the timeout. So this shouldn’t count as a circular dependency but Vite disagrees.

Reproduction

• Clone this repo
• Install dependencies with npm ci
• Run with npm start

System Info

System:
    OS: Linux 5.4 Linux Mint 20.2 (Uma)
    CPU: (8) x64 Intel(R) Core(TM) i7-3630QM CPU @ 2.40GHz
    Memory: 370.95 MB / 15.53 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 12.22.1 - /usr/local/bin/node
    Yarn: 1.22.10 - ~/.npm-global/bin/yarn
    npm: 7.19.1 - ~/.npm-global/bin/npm
  Browsers:
    Chrome: 91.0.4472.164
    Firefox: 90.0
  npmPackages:
    vite: ^2.4.2 => 2.4.2

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn’t already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it’s a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

[aleclarson]

but the circular dependency warning remains

Fixed by #3950

[Niputi]

closing as pr got merged and after test of reproduction it seems to be printing as expected according to conversation