Expose pendingRequests

Clear and concise description of the problem

I’m writing a plugin that collects a list of all the imported sass files and writes them to a single file instead. I can’t write them one by one because sass throws “variable not defined”, so the transform request for the combined file has to be stalled until no other modules are waiting to be resolved.

Suggested solution

Currently I’m using server._pendingRequests which is exactly what I was looking for, but it is a private property so really needs to be documented and exposed in a way that would be compatible with rollup. I proposed using this.pendingRequests in https://github.com/rollup/rollup/issues/4294.

Alternative

No response

Additional context

https://github.com/vuetifyjs/vuetify-loader/blob/274ce9ced8da65107b7544f9cdb2d82d463be313/packages/vite-plugin/src/stylesPlugin.ts

https://github.com/vuetifyjs/vuetify-loader/issues/225 https://github.com/rollup/rollup/issues/4294

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn’t already an issue that request the same feature to avoid creating a duplicate.

[sodatea]

Some background:

• We’ve discussed https://github.com/vitejs/vite/pull/4101 previously, but at that time _pendingReload is not reliable and doesn’t solve the concurrency problem. So we didn’t investigate further into that solution
• After https://github.com/vitejs/vite/pull/5452 the reliability issue seems to have been resolved.

So now I’m using it in vite-jest too. Seems worth exposing to me. We’ll discuss it at the next team meeting.

[bluwy]

I actually had to this something like this for my plugin, and thanks to your issue and code @KaelWD I implemented something similar like so:

// wait for all modules loaded before getting the entry ids
const seen = new Set()
let modulesToWait = []
do {
  modulesToWait = []
  for (const id of this.getModuleIds()) {
    if (seen.has(id)) continue
    seen.add(id)
    if (id.startsWith('\0')) continue
    const info = this.getModuleInfo(id)
    if (info?.isExternal) continue
    modulesToWait.push(this.load({ id }).catch(() => {}))
  }
  // TODO: timeout if too long
  await Promise.all(modulesToWait)
} while (modulesToWait.length > 0)

Besides the TODO, and that I’ve only tested it on a small project, it seems to be working well. I suppose this would work for Rollup too and I hope we can find a trick that works in both without Vite exposing pendingRequests.