Support for commonJS from npm for dev explicitly

Describe the bug

I’m trying to use a dependency that does not use ES module https://unpkg.com/choices.js@9.0.1/public/assets/scripts/choices.js and while it works during the build it doesn’t work during the dev with the error

The requested module ‘/@modules/choices.js/public/assets/scripts/choices.js’ does not provide an export named ‘default’

I tried to use optimizeDeps but it doesn’t work.

  optimizeDeps: {
    include: ['choices.js']
  }

Reproduction

Install choices.js and try to use it during development.

Suggestion / Idea

Is there an option to add commonjs to ES Module conversion for specific dependencies ? Something like :

commonJS: ['choices.js', 'dep2']

System Info

• vite version: 1.0.0-beta.11
• Operating System: Linux
• Node version: 14.5.0

[yyx990803]

• h.js has a valid single ESM file so it doesn’t need to be optimized/wrapped as ESM - it’s loaded directly as-is.
• m.js is CJS and therefore is optimized into ESM and then resolved from optimized modules. So yes it is because of the package names.

[shawntax]

I tested this out with two other packages with “.js” in the name, h.js and m.js, with Vite during development.

👍 h.js worked just fine. ❌ m.js gave the same Uncaught SyntaxError: The requested module '/@modules/m.js/m.js' does not provide an export named 'default' error.

Based on h.js working as expected, it seems the resolver can handle packages with .js in the name just fine, and it comes down to how individual packages handle ESM compatibility (and how tools handle interopability)?