`typeof process === "object"` shoud be replaced during dependencies build

Describe the bug

While using jotai I noticed it was running on production mode, so I did some research and discovered it uses typeof process === "object" to detect NODE_ENV. Although process.env.NODE_ENV is replaced during build, this specific pharse is not replaced.

Reproduction

Unsure, but try installing jotai and inspect its built sources inside node_modules/.vite

System Info

Output of npx envinfo --system --npmPackages vite,@vitejs/plugin-vue --binaries --browsers:

  System:
    OS: Windows 10 10.0.21387
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 8.47 GB / 23.72 GB
  Binaries:
    Node: 15.9.0 - ~\AppData\Local\Temp\xfs-22be641e\node.EXE
    Yarn: 2.4.1 - ~\AppData\Local\Temp\xfs-22be641e\yarn.EXE
    npm: 7.5.3 - ~\scoop\apps\nvm\current\nodejs\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.21387.1.0), Chromium (90.0.818.66)
    Internet Explorer: 11.0.21387.1

Since it looks like envinfo doesn’t support PnP, My vite version is 2.3.3.

Used package manager: yarn berry, but this shouldn’t be an issue here.

---

Before submitting the issue, please make sure you do the following

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn’t already an issue that reports the same bug to avoid creating a duplicate.
• Provide a description in this issue that describes the bug.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it’s a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

[Niputi]

I closed it as mentioned by Sodatea, jotai should make the check better and the application works fine and as expected with vite. please open the issue on jotai side so they can improve the check

[BasixKOR]

I didn’t mean it straight out doesn’t work but always falling back to production mode. However, I agree with the comment above that this should be solved on jotai’s side, so it is appropriate to close it anyway.