question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Dropping Dependence on `Newtonsoft.Json`

See original GitHub issue

Using this How to migrate from Newtonsoft.Json to System.Text.Json

If .NET core 3.1 should be the minimum supported framework version supported; It would be a great time to drop Newtonsoft.Json and use System.Text.Json

In the code, there is only a few things to consider;

  • Only used HttpEngine<T, TR> and in the two tests projects
  • Remove the [JsonProperty] everywhere camelcase is by convention
  • Remove the [JsonProperty] and replace with [System.Text.Json.JsonPropertyName] where properties are not conventional, like when using dashes.
  • StringBooleanConverter Migrate to System.Text.Json
  • DateRestrictJsonConverter Migrate to System.Text.Json
  • SortExpressionJsonConverter Migrate to System.Text.Json
  • StringEnumOrDefaultConverter Migrate to System.Text.Json
  • StringEnumListConverterTest remove, convert to DayOfWeek ?

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:20 (17 by maintainers)

github_iconTop GitHub Comments

2reactions
vivetcommented, Nov 30, 2022

I have merged the PR, and working on cosmetics refactoring and ensuring everything works. I expect release within 1-2 days

2reactions
vivetcommented, Nov 26, 2022

Not really. I have been busy with other projects. Though, it’s good that you ask, cause i should really get this done 😄. I will see to it during next week

Read more comments on GitHub >

github_iconTop Results From Across the Web

Could not load file or assembly 'Newtonsoft.Json' or one of ...
I had a post-build script that copied dependent assemblies from a dll library folder to the bin folder. A common setup from the...
Read more >
Replace the dependency on Newtonsoft.Json with new . ...
Json in .NET Core 3.1. Would be great to fully drop Newtonsoft, this library is one of the last few which still has...
Read more >
Upgrade: Nuget package dependency problem Newtonsoft.Json
This article provides information for addressing a problem occurring during Sitefinity upgrade due to nuget package dependency issue.
Read more >
Newton.json.dll not required in editor (2021.3.18f) but ...
Hey everbody! I'm working on a plugin that should mainly be distributed as a couple of dll files. One of those dll files...
Read more >
Does Hangfire have a dependency on Newtonsoft.Json ...
I use Hangfire core 1.5.2 , everything works fine as i was using the Newtonsoft.Json version came with the Hangfire installation ( Which...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found