Making ValueObject.GetEqualityComponents return IComparable is a breaking change

Previously GetEqualityComponents() returned IEnumerable<object>. Now it returns IEnumerable<IComparable>. If the ValueObject holds an Entity and it is used as an Equality Component it causes a compile time error if the Entity doesn’t implement IComparable.

What is the appropriate fix here? Every type that ValueObject uses as an Equality Component must now implement IComparable? Could this extend to the CSharpFunctionalExtensions Entity type so entities have it is available out-of-the-box?

[vkhorikov]

Yes, that’s a good idea. No particular reason why it’s not done yet. Appreciate if you could submit a PR.

[Szuuuken]

Hi, this is also a breaking change for any kind of list or array ValueObjects. The following Examples aren’t possible any more:

Value Object as an byte array

public class FileContent : SimpleValueObject<byte[]>
{
    public FileContent(byte[] value) : base(value)
    {
    }
}

Value Object as a List of ValueObjects

public class Thing: SimpleValueObject<string>
{
    public Thing(string value) : base(value)
    {
    }
}

public class MultpleThings: SimpleValueObject<List<Thing>>
{
    public MultpleThings(List<Thing> value) : base(value)
    {
    }
}

Do you have any suggestions how to solve such scenarios?