JsonBinaryType doesn't support String Object without quotes

Using hibernate-types-52 2.9.12 with PostgreSQL

I would like to be able to persist an arbitrary Object member in my entity using JSONB …

CREATE TABLE my_entity (
    id BIGSERIAL PRIMARY KEY,
    data JSONB,
);

@TypeDef(name = "jsonb", typeClass = JsonBinaryType.class)
public class MyEntity {

    @Type(type = "jsonb")
    @Column(columnDefinition = "json")
    private Object data;

    // Getters and setters removed for brevity
}

This works fine for the following cases …

myEntity.setData(List.of("hello"));
myEntity.setData(Map.of("hello", "world"));
myEntity.setData(null);
myEntity.setData(5);

But not for …

myEntity.setData("hello");

JsonParseException is thrown by the call to objectMapper.readTree(…) because instances of String do not get wrapped in quotes

I believe the fix here is to simply remove the instanceof conditional …

else if (Object.class.isAssignableFrom(type)) {
    return (X) objectMapperWrapper.toJsonNode(toString(value));
}

[vladmihalcea]

I’m not discarding this request since JSON is also used to save unvalidated data, hence it should be less strict.

I created the following branch on GitHub. The persist works fine. It’s just that the unwrapping needs to discard the quotes. I’ll have to find a way to fix that. If you have time, you could take a look and see whether there’s a clever way to address it.

[vladmihalcea]

@michaelcowan There are lots of test failures. It’s not as simple as just removing that check. You have to remember that these types have to work on Oracle, SQL Server, PostgreSQL, and MySQL.