ListArrayType should match the initial type when populating the List with the array from the DB

When having a entity like:

@Entity
@TypeDefs({
        @TypeDef(name = "list-array", typeClass = ListArrayType.class)
})
public class Circuit {

    @Column(name = "previous_names")
    @Type(type = "list-array")
    private List<String> previousNames = new ArrayList<>();

    ..

Could the ListArrayType add the names to the initiated list instead of replacing the list?

I’m wondering as when the array is null in the database the previousNames list will be null in the fetched entity. I’m having 2 feelings here as it makes sense if it’s null in the database.

But I expected differently.

Similar as

    @OneToMany(mappedBy = "project")
    private List<Task> tasks = new ArrayList<>();

will also give an empty list, even if no tasks would be found in the databse.

Maybe

    @Type(type = "list-array")
    private List<String> previousNames = new ArrayList<>();

could return an empty list.

and

    @Type(type = "list-array")
    private List<String> previousNames;

could return null.

What do you think?

[vladmihalcea]

You’re welcome. I think the current behavior follows the “principle_of_least_astonishment”, so it’s better to leave it as-is.

[marceloverdijk]

OK, I wasn’t aware of the @Basic property rules, but it makes sense. I indeed added a getter like that already. Thx again.