MonetaryAmountType should respect fractions digits when persisting to database

Some country don’t have any fraction digit. and when persisting should only store the whole number.

I fixed it by explicitly set the scale on getPropertyValue on https://github.com/vladmihalcea/hibernate-types/blob/7b022294534a9a109cc4749fd7ab9affdfd21d59/hibernate-types-60/src/main/java/com/vladmihalcea/hibernate/type/money/MonetaryAmountType.java#L34

My fix:

  @Override
  public Object getPropertyValue(MonetaryAmount component, int property) throws HibernateException {
    // alphabetical (amount, currency)
    switch (property) {
      case 0:
        return component
            .getNumber()
            .numberValue(BigDecimal.class)
            .setScale(
                component.getCurrency().getDefaultFractionDigits(),
                RoundingMode.HALF_UP
            );
      case 1:
        return component.getCurrency().getCurrencyCode();
    }
    return null;
  }
`

[vladmihalcea]

@stwonary Don’t worry about it. When I have some time, I’ll take your integration test case and see if I can provide a fix for it. Hopefully, in November, I’ll have some time to review it.

[stwonary]

I tried to implement for Hibernate 5.2 and Hibernate 5.5 without success. For some reason on those versions the values returned by getPropertyValue are totally ignored.

I hardcoded BigDecimal.valueOf(1) in getPropertyValue. The method is called but the valued persisted is still from the original monetaryAmount.getNumber().numberValue(BigDecimal.class)

any ideas?