Incorrect notification about missing required property
See original GitHub issueWhen defining the docker provider in a .tf
file without any other arguments, the plugin marks the code block as incorrect because it thinks the only required attribute, host
, is missing. Even though that is true (no host
argument defined in the block), according to the documentation, when the host
argument “is blank, the DOCKER_HOST environment variable will also be read”. If this is present, then the plugin should not mark that code block as invalid.
Please see below:
At the same time:
> env | grep -i DOCKER
DOCKER_CERT_PATH=/path/to/docker/vm
DOCKER_HOST=tcp://the.ip.with:port-defined
DOCKER_MACHINE_NAME=docker-vm-name
DOCKER_TLS_VERIFY=1
I think the plugin should be aware of the environment variables (the DOCKER_*
are usually set globally within a system so it should be able to detect/see them) and if the DOCKER_HOST
is present, it should not mark that block as invalid.
I am happy to contribute and send a PR for this, but I don’t see any contributing guideline so I wouldn’t be sure how to proceed.
Thanks and thank you for the plugin!
Issue Analytics
- State:
- Created 7 years ago
- Comments:9 (5 by maintainers)
Top GitHub Comments
@VladRassokhin Following walter’s comment, do you think a release for the work that has been done since October could see the light? thanks! 😃
Sorry for the delay. I just tried it and it works. Well done and thank you!