question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Regression? Comments are presereved in 0.26.4 but removed in 0.34.40

See original GitHub issue

While upgrading from 0.26.4 to 0.34.40 I encountered a change in how comments are rendered

diff --git a/readme.md b/readme.md
index 439cb14..67d01aa 100644
--- a/readme.md (rendered with flexmark 0.26.4)
+++ b/readme.md (rendered with flexmark 0.34.40)
@@ -24,7 +24,7 @@ part of your build. Distinguishing features of mdoc include:
 
 Table of contents:
 
-<!-- TOC depthFrom:2 -->
+TOC depthFrom:2 
 
 - [Quickstart](#quickstart)
   - [Library](#library)
@@ -46,7 +46,7 @@ Table of contents:
 - [Team](#team)
 - [--help](#--help)
 
-<!-- /TOC -->
+/TOC 
 

I expected the comments to be preserved like the behavior in v0.26.4.

The input markdown document contains html comments like this:

<!-- TOC depthFrom:2 -->

- [Quickstart](#quickstart)
  - [Library](#library)
  - [Command-line](#command-line)

<!-- /TOC -->

Is this change intended? I couldn’t find the release notes to see what has changed.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
vschcommented, Sep 28, 2018

@olafurpg, The bug is in the formatter. I will fix it.

0reactions
vschcommented, Sep 29, 2018

@olafurpg, thank you for catching it. I missed having a comment in the formatting test.

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found