Extension build using docker is failing to start

• I’m sure this issue is not a duplicate.

When I’m trying to run extension build using docker it fails.

Docker log

docker build -t dev docker/development
....
Successfully built 6dd12c1518cd
Successfully tagged dev:latest

docker run --rm -it -v $(PWD):/app dev
npm info it worked if it ends with ok
npm info using npm@5.4.2
npm info using node@v8.7.0
npm info lifecycle vscode-icons@7.19.0~preinstall: vscode-icons@7.19.0
npm WARN lifecycle vscode-icons@7.19.0~preinstall: cannot run in wd %s %s (wd=%s) vscode-icons@7.19.0 git submodule update --init --recursive /app
npm ERR! code ENOLOCAL
npm ERR! Could not install from "submodules/examples-generator" as it does not contain a package.json file.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-01-27T00_15_41_952Z-debug.log
module.js:473
      throw err;
      ^

Error: Cannot find module '/app/node_modules/vscode/bin/install'
    at Function.Module._resolveFilename (module.js:527:15)
    at Function.Module._load (module.js:453:25)
    at Function.Module.runMain (module.js:665:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3
npm info it worked if it ends with ok
npm info using npm@5.4.2
npm info using node@v8.7.0
npm info lifecycle vscode-icons@7.19.0~prebuild: vscode-icons@7.19.0

> vscode-icons@7.19.0 prebuild /app
> npm run lint && npm run test

npm info it worked if it ends with ok
npm info using npm@5.4.2
npm info using node@v8.7.0
npm info lifecycle vscode-icons@7.19.0~prelint: vscode-icons@7.19.0
npm info lifecycle vscode-icons@7.19.0~lint: vscode-icons@7.19.0

> vscode-icons@7.19.0 lint /app
> tslint -p .

sh: tslint: not found
npm info lifecycle vscode-icons@7.19.0~lint: Failed to exec lint script
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! vscode-icons@7.19.0 lint: `tslint -p .`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the vscode-icons@7.19.0 lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-01-27T00_15_42_558Z-debug.log
npm info lifecycle vscode-icons@7.19.0~prebuild: Failed to exec prebuild script
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! vscode-icons@7.19.0 prebuild: `npm run lint && npm run test`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the vscode-icons@7.19.0 prebuild script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-01-27T00_15_42_572Z-debug.log

</details

So we can see in log that it’s failing because of this:

npm WARN lifecycle vscode-icons@7.19.0~preinstall: cannot run in wd %s %s (wd=%s) vscode-icons@7.19.0 git submodule update --init --recursive /app

Possible solutions:

When I change install.sh to run git submodule update --init --recursive before npm i it installs packages correctly.

[artplan1]

@robertohuertasm tried your fix, it works. Thank you for quick response and fix.

[JimiC]

No. The problem is not with libgit. It’s just that the alpine image doesn’t have the tools needed to build nodegit. A PR will come soon.