question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

tsOfficial setting is ignored

See original GitHub issue
  • I’m sure this issue is not a duplicate
  • I want to create an icon request(if not, remove these lines below)

No matter if I set "vsicons.presets.tsOfficial": false to true or false, or even remove it entirely, I always see the official TS icon displayed in my files list:

screenshot 2017-06-09 15 21 31

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:15 (15 by maintainers)

github_iconTop GitHub Comments

2reactions
lumaxiscommented, Jun 9, 2017

@robertohuertasm None taken and absolutely fair point!

My biggest issue with this is discoverability and the way this differs from my (and I’m naively presuming other users’) expectation of how settings in VS Code work. I have not ever seen another built-in VS Code setting or extension setting that required me to execute a manual task without me explicitly prompting about it. And I really customize a lot of things 🙂

The only things that I have experienced so far are were extensions that either required me to reload/restart or click a button in the toast that showed after I changed a setting. The way vscode-icons handles this right now is in my opinion not optimally designed as it goes against everything I’m used to since the time I started using VS Code. I strongly disagree with you on this:

The idea of leaving this process completely unobstrusive was to not annoy the user with every time she changes the configuration.

While I agree that it’s a good goal to be unobtrusive, I don’t think it’s unreasonable to show a toast when a user manually changes a setting. Realistically, how often does a user change a preset? And when they do, are there many cases where they would not want to apply them?

My point boils down to this: It’s all good that this is documented and the documentation well written and clear but in my view, a well-designed system should be usable without having to read the documentation.

But then again, maybe this isn’t a problem for other users at all? The lack of other Issues about the same problem surprised me, so maybe I’m totally wrong here 🙂

1reaction
JimiCcommented, Jun 10, 2017

The think is that vscode itself uses the detection technic, upon saving the settings file, to enable/disable its features and settings. And this is what the user expects as a UX from the extensions as well. So @lumaxis has a strong point. On the other hand, we had our shares of complaints about being intrusive and we are now very cautious with it. There is also an issue on vscode about extensions messages being too annoying.

  1. React only to changes affecting vscode-icons settings

I’m confident that this is achievable.

  1. Allow the user to turn on/off this behavior.

This is the tricky part.

Read more comments on GitHub >

github_iconTop Results From Across the Web

TSConfig Reference - Docs on every TSConfig option
true unreachable code is ignored; false raises compiler errors about unreachable code. These warnings are only about code which is provably unreachable due...
Read more >
Include announcement section for extension authors · Issue #27993 ...
Sometimes extension authors like me at settings-sync need to announce something, ... tsOfficial setting is ignored vscode-icons/vscode-icons#1015.
Read more >
how ignore typescript errors with @ts-ignore? - Stack Overflow
I recommend allowing @ts-ignore with an enforced description. This can be achieved by the following config ...
Read more >
ban-ts-ignore - Rule
Rule: ban-ts-ignore. Bans “// @ts-ignore” comments from being used. Notes: TS Only. Config. Not configurable. Config examples. "ban-ts-ignore": true. Schema.
Read more >
Clubbin Beatz - Sine ( remixed by TS ) [official Video] - YouTube
Clubbin Beatz - Sine ( remixed by TS ) [official Video] - free House ... Twitter: https://twitter.com/phonic_ps Tags ( ignore ): typebeat, ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found