Please stop writing "WARNING: No active editor during save. Nothing saved." to the Helm output channel
See original GitHub issueCurrently when ANY document is saved and there is no active editor, the extension logs WARNING: No active editor during save. Nothing saved.
to the Helm
output channel (and forces the output channel to show itself 😢)
This is causing issues with GitLens’ new settings editor (since it is a previewHtml – not an editor) and it saves settings which seems to cause vscode to fire an onDidSaveTextDocument
event.
Here is the offending line: https://github.com/Azure/vscode-kubernetes-tools/blob/43210bbc8edac9cb075a63f26fd51fb11ba3285f/src/extension.ts#L162
Also here is where it is forcing the output panel to show each time something is logged – I hope this can be removed too. https://github.com/Azure/vscode-kubernetes-tools/blob/43210bbc8edac9cb075a63f26fd51fb11ba3285f/src/logger.ts#L20
Issue Analytics
- State:
- Created 6 years ago
- Reactions:1
- Comments:5
Top GitHub Comments
Thanks for flagging this. I’ve noticed that some of the Helm bits can be a bit over-enthusiastic. I’ll figure out why it wants to warn about this and get it fixed so it errs on the side of non-noisiness.
No worries — thank you again!